optics-dev / Monocle

Optics library for Scala
https://www.optics.dev/Monocle/
MIT License
1.64k stars 205 forks source link

Update sbt-mdoc to 2.5.0 #1404

Closed scala-steward closed 8 months ago

scala-steward commented 8 months ago

About this PR

📦 Updates org.scalameta:sbt-mdoc from 2.4.0 to 2.5.0

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates Add this to your `.scala-steward.conf` file to ignore future updates of this dependency: ``` updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-mdoc" } ] ``` Or, add this to slow down future updates of this dependency: ``` dependencyOverrides = [{ pullRequests = { frequency = "30 days" }, dependency = { groupId = "org.scalameta", artifactId = "sbt-mdoc" } }] ```

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, commit-count:1

xuwei-k commented 8 months ago

Important notice: JDK 8 will no longer be supported due to changes in dependencies of mdoc. We now require 11+

🤔

armanbilge commented 8 months ago

Looks like CI is broken and is not actually running mdoc anymore. https://github.com/optics-dev/Monocle/blob/a7b1328c1e8d401981993da10472928ab144d4d6/.github/workflows/ci.yml#L99-L101

armanbilge commented 8 months ago
armanbilge commented 8 months ago

Oh, that is excellent 😁

[info] running monocle.docs.Main 
Error: Exception in thread "sbt-bg-threads-1" java.lang.UnsupportedClassVersionError: mdoc/MainSettings$ has been compiled by a more recent version of the Java Runtime (class file version 55.0), this version of the Java Runtime only recognizes class file versions up to 52.0
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
    at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
    at java.net.URLClassLoader.defineClass(URLClassLoader.java:473)
    at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
    at sbt.internal.ManagedClassLoader.findClass(ManagedClassLoader.java:103)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
    at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
    at monocle.docs.Main$.main(Main.scala:31)
    at monocle.docs.Main.main(Main.scala)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at sbt.Run.invokeMain(Run.scala:144)
    at sbt.Run.execute$1(Run.scala:94)
    at sbt.Run.$anonfun$runWithLoader$5(Run.scala:121)
    at sbt.Run$.executeSuccess(Run.scala:187)
    at sbt.Run.runWithLoader(Run.scala:121)
    at sbt.Defaults$.$anonfun$bgRunTask$6(Defaults.scala:1988)
    at sbt.Defaults$.$anonfun$termWrapper$2(Defaults.scala:1927)
    at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
    at scala.util.Try$.apply(Try.scala:213)
    at sbt.internal.BackgroundThreadPool$BackgroundRunnable.run(DefaultBackgroundJobService.scala:367)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
    at java.lang.Thread.run(Thread.java:750)
[success] Total time: 13 s, completed Nov 8, 2023 10:40:50 PM
xuwei-k commented 8 months ago
scala-steward commented 8 months ago

Superseded by #1407.