search

optics-dev / Monocly

Optics experimentation for Dotty
MIT License
32 stars 5 forks source link

Remove obsolete experiments, update Monocly to reflect locked-in aspects of Monocle 3 #16

Closed kenbot closed 3 years ago

kenbot commented 3 years ago

Monocly has been a test bed of many possible approaches for Monocle 3. We are now putting a lot of work into the complex machinery of the Focus macro, and I am concerned that it might be getting too tightly ensnared with Monocly experiments, some of which are out of date.

For instance, given the success of compose overloading experimenting, the AndThen typeclass is unlikely to be retained.

We should do some periodic spring cleaning, so that we don't face a catastrophic rewrite when it comes time to integrate the complex Focus work into the real Monocle 3 branch.

kenbot commented 3 years ago

Naively removing AndThen makes type inference worse, and breaks the JSON tests. I don't want to get bogged down in this, @julien-truffaut has put a ton of work and thought into this, and I'd rather focus on the macro.

So I'm recasting this as a general issue relating to spring cleaning.

julien-truffaut commented 3 years ago

Good call @kenbot, I will try to do clean-up early this week.

julien-truffaut commented 3 years ago

An alternative is to work directly in the main Monocle directory. For example, we could create a macro3 module for macros specific to Scala 3.

Let me know what you prefer, I can do the groundwork on either case.

kenbot commented 3 years ago

I think there is still some speculative stuff left to try that might be better out of harm's way.

On Mon, 18 Jan 2021, 9:57 pm Julien Truffaut, notifications@github.com wrote:

An alternative is to work directly in the main Monocle directory. For example, we could create a macro3 module for macros specific to Scala 3.

Let me know what you prefer, I can do the groundworkd on either case.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/optics-dev/Monocly/issues/16#issuecomment-762169501, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACNIY2CR73KZE4DJ6SFTPTS2QHYXANCNFSM4WCQVW2A .