search

opticspy / lightpipes

LightPipes for Python, "Pure Python version"
https://opticspy.github.io/lightpipes/
BSD 3-Clause "New" or "Revised" License
232 stars 54 forks source link

work flow #11

Open guyskk opened 7 years ago

guyskk commented 7 years ago

fork & PR is a efficient work flow to cooperation, let's try it:

  1. fork this repo by click Fork button at right top

  2. change remote origin to your own repo and remote upstream to this repo:

    git remote set-url origin YOUR_OWN_REPO_URL
git remote add upstream git@github.com:opticspy/lightpipes.git

  3. run git remote -v, you will see something like this:

    origin  git@github.com:guyskk/lightpipes.git (fetch)
origin  git@github.com:guyskk/lightpipes.git (push)
upstream    git@github.com:opticspy/lightpipes.git (fetch)
upstream    git@github.com:opticspy/lightpipes.git (push)

  4. to work on something new, create a descriptively named branch off of master, and commit/push to the new branch, when it ready for merging, open a pull request.

  5. to update local branch with upstream, see here: https://help.github.com/articles/syncing-a-fork/

see also: http://scottchacon.com/2011/08/31/github-flow.html

FredvanGoor commented 7 years ago

Hi Guyskk,

Good job that conda stuff!

I have successfully created windows wheels for python 2.7, 3.4, 3.5 and 3.6 For python 3.6 I had to change the version of numpy to 1.12.0 in the requires.txt file. (With numpy==1.10.4 there was an error while building numpy for python 3.6). I have tested the wheels on my 3 windows computers (including an old 32 bits windows 7 machine)

I will do the branching.

Fred