search

optimad / bitpit

Open source library for scientific HPC
http://optimad.github.io/bitpit/
GNU Lesser General Public License v3.0
117 stars 33 forks source link

Cramer solvability condition #283

Closed marcocisternino closed 2 years ago

marcocisternino commented 2 years ago

Sure

Marco Cisternino, PhD @.**@.>

Optimad Engineering Srl Via Bligny 5, Torino, Italia. +3901119719782 www.optimad.ithttp://www.optimad.it/

From: Andrea Iob @.> Sent: giovedì 17 febbraio 2022 18:01 To: optimad/bitpit @.> Cc: Marco Cisternino @.>; Author @.> Subject: Re: [optimad/bitpit] Cramer solvability condition (PR #283)

@andrea-iob approved this pull request.

For consistency with the rest of bitpit, can we use std::abs instead of fabs?

— Reply to this email directly, view it on GitHubhttps://github.com/optimad/bitpit/pull/283#pullrequestreview-886277469, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSMIGB5U5IONG2FUBX6L73U3USV3ANCNFSM5OVGRVNA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.**@.>>

andrea-iob commented 2 years ago

I've replaced fbas with std::abs.