search

optimad / bitpit

Open source library for scientific HPC
http://optimad.github.io/bitpit/
GNU Lesser General Public License v3.0
117 stars 33 forks source link

voloctree: reduce visibitiy of PABLO messages #317

Closed andrea-iob closed 2 years ago

andrea-iob commented 2 years ago

In release mode, VolOctree patch will display PABLO messages only when their severity is WARNING or higher.

To achieve this I had to rework a bit the logger: loggers that were sharing the same buffer were sharing also the visibility settings, but this was not the intended behaviour. Other than fixing this problem, the reworked logger should be faster.

andrea-iob commented 2 years ago

I had to make some changes to make the code work with GCC 12 (and hopefully clang, tests will confirm this). Now, stream operators for bitpit classes are declared inside the bitpit namespace. Since at least one of the arguments passed to those stream operators are in the bitpit namespace, the compiler is still able to pick the correct overload thanks to ADL (Argument-dependent lookup);

marcocisternino commented 2 years ago

Can you rebase on master, please? Thanks!