search

optimad / bitpit

Open source library for scientific HPC
http://optimad.github.io/bitpit/
GNU Lesser General Public License v3.0
117 stars 34 forks source link

patchkernel: fix incorrect id conversions #337

Closed DMurataj01 closed 1 year ago

DMurataj01 commented 1 year ago

Changes look good. May I ask you to squash the last two commits together and, for consistency with the current git history, use the format "patchkernel: ..." for the commit messages? Thanks.

Noted for next time, @andrea-iob Are you able to just squash merge & update the commit msg that way for now?

andrea-iob commented 1 year ago

I don't think I can do that directly, because the merge request comes from a repository I don't have write access to. I'll find a way.

andrea-iob commented 1 year ago

Superseded by #342.