Closed arnodu closed 1 year ago
Hi @arnodu, thanks for the warning. We'll address the issue soon.
@arnodu Can you please check if #350 fixes the problem?
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 347843abd..91e90079c 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -27,7 +27,7 @@
#------------------------------------------------------------------------------------#
cmake_minimum_required(VERSION 3.10)
-project("bitpit" CXX)
+project("bitpit" C CXX)
#------------------------------------------------------------------------------------#
# Variables visible to the user
diff --git a/external/git/cmake/GetGitRevisionDescription.cmake b/external/git/cmake/GetGitRevisionDescription.cmake
index 1f233308a..88d8d3cca 100644
--- a/external/git/cmake/GetGitRevisionDescription.cmake
+++ b/external/git/cmake/GetGitRevisionDescription.cmake
@@ -84,6 +84,9 @@ function(_git_find_closest_git_dir _start_dir _git_dir_var)
endfunction()
function(get_git_head_revision _refspecvar _hashvar)
+if(NOT GIT_FOUND)
+find_package(Git QUIET)
+endif()
_git_find_closest_git_dir("${CMAKE_CURRENT_SOURCE_DIR}" GIT_DIR)
if(${ARGC} GREATER 2})
Du you want me to open separate issues for that or are you already aware of them?
@arnodu Can you please check if #353 fixes the problem with git?
Yes, thanks it fixes the issue with get_git_head_revision
I have an issue when i compile bitpit with clang and it's own libc++.
I used bitpit's commit 7225403e0ac
Mainly :
You need a cast to
bool
here to be compatible with thestd::bitset::operator[]
return value that may not bebool
directly :Since i only use PABLO, there may be other locations in the rest of bitpit's codebase where this happens.