search

optimad / bitpit

Open source library for scientific HPC
http://optimad.github.io/bitpit/
GNU Lesser General Public License v3.0
116 stars 33 forks source link

patchkernel: fix evaluation of voxel volume #382

Closed andrea-iob closed 1 year ago

andrea-iob commented 1 year ago

The formula for evaluating the volume needs the position of four vertices that identifies the x, y, and z edges.

andrea-iob commented 1 year ago

Pull request #383 will introduce a test for the unstructured patch that checks the evaluation of cell volumes (admittedly, it will be a very basic test, but still an improvement over the current situation where there are no tests).