optimad / bitpit

Open source library for scientific HPC
http://optimad.github.io/bitpit/
GNU Lesser General Public License v3.0
116 stars 34 forks source link

voloctree: fix performance-move-const-arg clang tidy error in importCells (+ correct local typo) #386

Closed DMurataj01 closed 1 year ago

andrea-iob commented 1 year ago

Out of curiosity, do you have more information on why using a copy is better than using move?

DMurataj01 commented 1 year ago

Out of curiosity, do you have more information on why using a copy is better than using move?

Not exactly sure, we have clang-tidy as part of our pipeline and this is something which I've had to fixup