search

optimad / bitpit

Open source library for scientific HPC
http://optimad.github.io/bitpit/
GNU Lesser General Public License v3.0
116 stars 34 forks source link

levelset: fix evaluation of levelset on segmentation with pixel elements #400

Closed andrea-iob closed 1 year ago

andrea-iob commented 1 year ago

There were still some cases where the pixel's vertices were not properly ordered before passing them to the CG utilities.

Depends on #394.

marcocisternino commented 1 year ago

We are using "anti-clockwise ordered", "counter-clockwise ordered" and "ordered" in doc, variable names and method prototypes. I suppose all the three expressions mean exactly the same thing, i.e. "counter-clockwise ordered". If this is the case, couldn't we use the same expression everywhere? Even only "ordered" is good to me, being explained in high level doc that ordered vertices are always counter-clockwise ordered. I would preferer to be more clear by always specifying "counter-clockwise ordered" or "CCW" for sake of conciseness

andrea-iob commented 1 year ago

I've updated the documentation and some function/variable names.