optimad / bitpit

Open source library for scientific HPC
http://optimad.github.io/bitpit/
GNU Lesser General Public License v3.0
115 stars 34 forks source link

RBF: fix matrix definition in solve and solveLSQ methods #433

Closed edoardolombardi closed 7 months ago

edoardolombardi commented 7 months ago

The pull fixes the construction of the matrix of the system solved during interpolation by RBFs (for both full problem and greedy algorithm).

In case of variable support radii of the RBFs the matrices were filled in the wrong order producing incorrect results.

Tiny fix to avoid redefinition of local variables inside functions is also introduced during the fixing.