search

optimad / mimmo

Surface manipulation and mesh morphing library
http://optimad.github.io/mimmo
GNU Lesser General Public License v3.0
99 stars 21 forks source link

Provide findPackage files for external dependencies #157

Closed edoardolombardi closed 3 years ago

edoardolombardi commented 3 years ago

External dependencies in mimmo are forced in CMakeLists file (e.g. CGNS library)

Providing findPackage file for external dependencies (as for CGNS) would be useful and aligned with bitpit and other external packages.

roccoarpa commented 3 years ago

just a quick comment: it could not so easy to retrieve/write from scratch findPackage or Config.cmake for all the dependencies embedded in mimmo. Openfoam it's the counterpart example of CGNS in this context. Sometimes, according to the type of libraries, tons of collateral info should be checked safely by the findPackage(installation subfolder locations, config options on different OS platforms, different compiler options). If a version distributed by the vendor of the dependancy or by some official trusted institutution (like INRIA f.e. or Kitware itself) it's not available, writing it from scratch could be challenging. A more realistic approach could be to enable the findPackage when it's possible, in my opinion .

roccoarpa commented 3 years ago

a partial porting including CGNS, Metis and parMetis using find_package is already done. OpenFoam dep inclusion is still under investigation.

roccoarpa commented 3 years ago

ported also OpenFoam automatic search with a cmake function