Closed sidd3888 closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
b77deb8
) 92.98% compared to head (2fef810
) 92.98%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @sidd3888, thank you very much for your Pull Request. The changes are great. There is just one more thing: It would be great to also have a small test case for the get_weighting_matrix
with the "identity" option.
Let me know whether you want to add this test or I should do it. If you want to add the test, it should be in this file
If I understand the code there correctly, this would require nothing more than just adding "identity" as a possible option (and accordingly altering the test) for the get_weighting_matrix
test right? I can add that to this PR right away.
Yes. Thank you so much!
Added the identity weighting matrix to the MSM estimation:
get_weighting_matrix()
function to allow for the identity matrix"identity"
as a valid option for weights inestimate_msm()