search

optimagic-dev / optimagic

optimagic is a Python package for numerical optimization. It is a unified interface to optimizers from SciPy, NlOpt and other packages. optimagic's minimize function works just like SciPy's, so you don't have to adjust your code. You simply get more optimizers for free. On top you get diagnostic tools, parallel numerical derivatives and more.
https://optimagic.readthedocs.io/
MIT License
270 stars 30 forks source link

Update scaling argument handling #508

Closed timmens closed 4 months ago

timmens commented 4 months ago

In this PR, I update the scaling argument handling.

[!NOTE] I chose to stick with the ScalingOptionsDict, as it gives you autocomplete in the editor. See below.

image

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 82.08955% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (0.5.0@75fa2f2). Learn more about missing BASE report.

Files Patch % Lines
...imagic/optimization/create_optimization_problem.py 62.00% 19 Missing :warning:
src/optimagic/parameters/scale_conversion.py 88.57% 4 Missing :warning:
src/optimagic/parameters/scaling.py 96.87% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.5.0 #508 +/- ## ======================================== Coverage ? 90.37% ======================================== Files ? 102 Lines ? 9493 Branches ? 0 ======================================== Hits ? 8579 Misses ? 914 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.