Closed schroedk closed 2 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Attention: Patch coverage is 94.16283%
with 38 lines
in your changes missing coverage. Please review.
Project coverage is 90.90%. Comparing base (
354155d
) to head (3d815fc
). Report is 1 commits behind head on 0.5.0.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I am through now. Thanks a lot for this PR!
One thing that is left to do is adding a
logger
field to theOptimizeResult
.
Done
The proposed logging is described here.
This refactoring introduces the following abstractions:
LogOptions
(implementationSQLiteLogOptions
), configurationLogStore
(implementation_SQLiteLogStore
, not exposed), write accessLogReader
(implementationSQLiteLogReader
), read accessThe old class
OptimizationLogReader
redirects toSQLiteLogReader
in a backward-compatible way.