Java 8 upgrade - Githubissues

optimaize / language-detector

Language Detection Library for Java

Apache License 2.0

568 stars 165 forks source link

Java 8 upgrade #83

Closed vvagaytsev closed 2 years ago

vvagaytsev commented 6 years ago

Covers the issue #76 . It can be maintained in a separate branch under the different artifact name (like language-detector-java-8) if the compatibility with the deprecated Java versions matters.

The commits include some language level changes as well. There are still some code places where Java 8 Stream API can be used. I can chnage those too.

Feel free to contact me and give any feedback.

Regards, Vladimir

seinecle commented 4 years ago

Two remarks on the Java 8 version:

would be nice if it would enable to drop the dependency to Guava
streams or parallel streams? Parallel streams have some overheads, which are not worth it when the task is particularly short.