optimajet / WorkflowEngine.NET

WorkflowEngine.NET - component that adds workflow in your application. It can be fully integrated into your application, or be in the form of a specific service (such as a web service).
https://workflowengine.io
870 stars 246 forks source link

Calling the MSSQLProvider.GetSchemesAsync method results in an exception when a scheme does not have inlined schemes #100

Closed royvandertuuk closed 2 years ago

royvandertuuk commented 2 years ago

Schemes without any inlined schemes have a null value in the ‘InlinedSchemes’ column in the ‘WorkflowScheme’ table. The GetInlinedSchemes method called from MSSQLProvider.GetSchemesAsync does not check for null and this results in Newtonsoft throwing the ArgumentNullException.

https://github.com/optimajet/WorkflowEngine.NET/blob/ba9176e74800289eda6a4517e56d27e142388e0f/Providers/OptimaJet.Workflow.MSSQL/MSSQLProvider.cs#L146

https://github.com/optimajet/WorkflowEngine.NET/blob/ba9176e74800289eda6a4517e56d27e142388e0f/Providers/OptimaJet.Workflow.MSSQL/Models/WorkflowScheme.cs#L93

shalugin commented 2 years ago

@royvandertuuk Thanks for submitting this issue. We will fix this in a future release.

shalugin commented 2 years ago

Fixed in 5.2.0 release