search

optimamodel / optima

Optima HIV software tool
http://optimamodel.com
GNU Lesser General Public License v3.0
7 stars 1 forks source link

Fix portfolios again #1737

Closed cliffckerr closed 6 years ago

cliffckerr commented 6 years ago

aside from this stubbornly persistent issue which has no easy fix, and doesn't just apply to portfolios:

https://trello.com/c/pXrr12jm/943-handling-of-baseline-optimization-in-portfolios

this PR fixes the bug with portfolios breaking. @robynstuart pls review.

robynstuart commented 6 years ago

@cliffckerr I got an error when running batchboctedivoire on this branch.

Elapsed time for reoptimizeprojects: 462 s
    Printing results...
Traceback (most recent call last):
  File "batchcotedivoire.py", line 125, in <module>
    F.runGA(maxtime=maxtime, maxiters=maxiters, maxload=maxload, randseed=randseed)
  File "/home/robyn/optima/optima/portfolio.py", line 294, in runGA
    if self.results: self.makeoutput(doprint=doprint, verbose=verbose)
  File "/home/robyn/optima/optima/portfolio.py", line 392, in makeoutput
    projoutcomesplit[k][io]['num'+obkey] = self.results[key][iokeys[-1]].main['num'+obkey].tot[ionum][bestindex][indices[io]].sum()     # Again, current and optimal
 should be same for 0 second optimisation, but being explicit -- WARNING, need to fix properly!
IndexError: invalid index to scalar variable.
cliffckerr commented 6 years ago

@robynstuart there isn't enough information for me to replicate that error -- when i run that file it can't find the files it needs, even if i run cotedivoire.py first

cliffckerr commented 6 years ago

@robynstuart having looked at it more closely, i don't think this is an easy fix, so i'm closing this PR