optimistex / ngx-select-ex

Angular based replacement for select boxes
https://optimistex.github.io/ngx-select-ex/
MIT License
111 stars 42 forks source link

feat: pass search text to not found template #110

Closed oscarlocatelli closed 6 years ago

oscarlocatelli commented 6 years ago

If the search text is not found in available options "not found template" is shown, but missing the possibility to simply get the text.

I've passed it through the ngTemplateOutletContext.

It could be useful if you want to add this text as new item with a button as in your example (updated).

codecov-io commented 6 years ago

Codecov Report

Merging #110 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   90.81%   90.88%   +0.07%     
==========================================
  Files          15       15              
  Lines         468      472       +4     
  Branches       70       71       +1     
==========================================
+ Hits          425      429       +4     
  Misses         18       18              
  Partials       25       25
Impacted Files Coverage Δ
src/app/lib/ngx-select/ngx-select.component.ts 89.75% <100%> (+0.12%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96aaec5...f0043ca. Read the comment docs.

oscarlocatelli commented 6 years ago

I've also fixed in f0043cae4d954cb0e7b286ba3e6f81367d7c47c3 the Travis CI reported problem on inputElRef accessibility creating a getter property.

Maybe you want to change this with another solution..

oscarlocatelli commented 6 years ago

Hi @optimistex ,

Any feedback about this PR? It is a simple addition, but useful in some case.

Tahk's

optimistex commented 6 years ago

@oscarlocatelli Thanks for your job! Good idea and it's great that you added it ))

oscarlocatelli commented 6 years ago

@optimistex Thank's at you for the merge.