optimizely / android-sdk

Android SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/android-sdk
Apache License 2.0
55 stars 39 forks source link

Add git actions of clean, build and unit test android sdk #403

Closed mnoman09 closed 2 years ago

mnoman09 commented 2 years ago

Summary

Test plan

All unit tests should pass

jaeopt commented 2 years ago

@mnoman09 I see you keep api-level 29. It'll be good to have AVDs 31 or 32 instead of 29. Wondering if actions have limitations on using them?

mnoman09 commented 2 years ago

ering if actions have limitations on using them?

yes, currently I am facing issues with starting emulator with api level 31 and 32. Will add it in future when the bugs are resolved.

mnoman09 commented 2 years ago

It looks good with a small change requested. I understand we can remove .travis.yml and disconnect travis from this repository. Can we add other tasks (Integration Tests, Publish, etc) to actions too?

We can not add integration tests in gitAction as then we have to change the entire flow. we can discuss this offline with @msohailhussain .

jaeopt commented 2 years ago

Covered by PR-411 already.