optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk
Apache License 2.0
19 stars 20 forks source link

fix: Change string.Format style to string interpolation #225

Closed msohailhussain closed 4 years ago

msohailhussain commented 4 years ago

Summary

Test plan

msohailhussain commented 4 years ago

Sure, I will share results.

msohailhussain commented 4 years ago

@mikeng13 I tested it separately and don't see any major difference. For more than 150K+ requests it took 0.5 seconds for this log. string.Format(@"{0} Variation ""{1}"" is mapped to experiment ""{2}"" and user ""{3}"" in the forced variation map", Logger.DEBUG, experimentKey, variationKey, i.ToString()); and I see more or less the same time (avg 0.445 sec) $@"{Logger.DEBUG} Variation ""{ experimentKey}"" is mapped to experiment ""{variationKey}"" and user ""{i.ToString()}"" in the forced variation map";

mikeproeng37 commented 4 years ago

Thanks