bug: Handle null, empty, or whitespaces for RolloutId

optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk

Apache License 2.0

19 stars 20 forks source link

bug: Handle null, empty, or whitespaces for RolloutId #304

Closed mikechu-optimizely closed 2 years ago

mikechu-optimizely commented 2 years ago

Summary

Handle possible empty string rolloutId in datafile

An empty string rolloutId should be ignored and not raise and exception

Test plan

Unit test added to OptimizelySDK.Tests/ProjectConfigTest.cs

Issues

OASIS-8370

mikechu-optimizely commented 2 years ago

@msohailhussain I don't seem to have access to edit the CI GitHub Action where I can figure out how to correct this error.

2022-07-14 17:38:01 [ERROR]   Failed to get [GITHUB_TOKEN]!
2022-07-14 17:38:01 [ERROR]   []
2022-07-14 17:38:01 [ERROR]   Please set a [GITHUB_TOKEN] from the main workflow environment to take advantage of multiple status reports!

I see that it's not a required Check, but I like all ✔️ 🤷

msohailhussain commented 2 years ago

@mikechu-optimizely in unit tests add one more case for passing null