feat: Datafile parsing + audience evaluation for ODP integration

optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk

Apache License 2.0

19 stars 20 forks source link

feat: Datafile parsing + audience evaluation for ODP integration #305

Closed mikechu-optimizely closed 2 years ago

mikechu-optimizely commented 2 years ago

Summary

Parse new integrations section of the datafile
Evaluate() using UserContext

Test plan

Run full OptimizelySDK.Tests project/suite

Issues

OASIS-8392

mikechu-optimizely commented 2 years ago

@jaeopt This PR was approved but I would like your view on it too.

Note: I'm holding on merging until 3.11.1 is released.

mikechu-optimizely commented 2 years ago

Most changes look good. We see public getter/setter for qualifiedSegments missing in OptimizelyUserContext. I also see several "deprecation" github warnings. Is this normal?

@jaeopt The deprecation warnings need a separate chore+PR to resolve in my opinion.