search

optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk
Apache License 2.0
19 stars 20 forks source link

feat: Added a generic LRUCache interface and a default implementation #311

Closed mikechu-optimizely closed 2 years ago

mikechu-optimizely commented 2 years ago

Summary

Added an interface for a LRU Caching mechanism using generics. Include a default implementation.

Test plan

Included new tests in the test project

Issues

OASIS-8407

mikechu-optimizely commented 2 years ago

@jaeopt Would you like for this Pull Request to also wait for @msohailhussain 's approval?

jaeopt commented 2 years ago

@jaeopt Would you like for this Pull Request to also wait for @msohailhussain 's approval?

Yes for all PRs. Unfortunately, I cannot cover csharp lang stuffs :)

mikechu-optimizely commented 2 years ago

@msohailhussain Can you take a look at this Pull Request and the suggested LRU implementation when you have a chance?

mikechu-optimizely commented 2 years ago

@msohailhussain This is ready for another review after our conversation.