search

optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk
Apache License 2.0
19 stars 20 forks source link

feat: ODP REST API for Sending ODP Events #315

Closed mikechu-optimizely closed 1 year ago

mikechu-optimizely commented 1 year ago

Summary

Adding module to provide an internal service for sending events to ODP's REST API.

Test plan

Issues

mikechu-optimizely commented 1 year ago

@msohailhussain Let me know if you want to pair up over this review.

mikechu-optimizely commented 1 year ago

LGTM

Thanks @jaeopt . Holding for @msohailhussain 's approval 😉

msohailhussain commented 1 year ago

@mikechu-optimizely Overall your PR looks good, please address 4 more questions and then lgtm.

msohailhussain commented 1 year ago

last but not least please fix Lint issues.

mikechu-optimizely commented 1 year ago

last but not least please fix Lint issues.

It seems like the lint error here in the GitHub Action is about a missing auth token.

Would you like me to pause the Pull Request and resolve this step, so we can make the "Csharp CI with .NET / Lint Code Base (pull_request)" required?

...or are there lint issues that I missed in the code? Can you direct me to an example file?

msohailhussain commented 1 year ago

this is fine for me, we should resolve token issue in future.