feat: Added ODPEventManager implementation

optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk

Apache License 2.0

19 stars 20 forks source link

feat: Added ODPEventManager implementation #317

Closed mikechu-optimizely closed 1 year ago

mikechu-optimizely commented 1 year ago

Summary

Added OdpEventManager implementation.

Test plan

Unit tests added
Existing tests continue to pass

Jira

FSSDK-8444

mikechu-optimizely commented 1 year ago

Sorry about the extra files included in this PR. The upgrade of NUnit version 2.6.4 to latest 3.13.3 to get control over single thread test execution also required touching older test files.

mikechu-optimizely commented 1 year ago

Once we've finished collaborating/finishing reviews in this PR, I may need to close it and open a new one.

Yesterday, I made the names of the GitHub Actions more descriptive, which decoupled the branch protection rules. This means that some of the tasks that are Required will never be satisfied to squash and merge.

jaeopt commented 1 year ago

@mikechu-optimizely github behaves strange. I see my all other comments disappeared :) Let me check how to recover them.

jaeopt commented 1 year ago

@mikechu-optimizely github behaves strange. I see my all other comments disappeared :) Let me check how to recover them.

I see that all other comments have been appended as reply to the previous review comments. I see a few items not covered yet or with possible issue. Please review them as well.

mikechu-optimizely commented 1 year ago

@mikechu-optimizely github behaves strange. I see my all other comments disappeared :) Let me check how to recover them.

I think I figured out that I had to use the Unresolve button to show your replies. It is strange for sure. I'm going through your comments now. Thanks for the new review.

mikechu-optimizely commented 1 year ago

Sorry for all the commits and PR updates.

I have a solid CI now, and I'm ready for another review @msohailhussain and @jaeopt

mikechu-optimizely commented 1 year ago

Thank you both for the reviews. I will walk more carefully through future reviews to find all the updates and more slowly & thoughtfully address each.

If I could get another review of the latest changes, I would much appreciate further feedback.

@msohailhussain @jaeopt

mikechu-optimizely commented 1 year ago

Closing/Abandoning:

Large changes requested
New required GitHub Actions to adjust

I'll open a new PR