Closed mikechu-optimizely closed 1 year ago
@mikechu-optimizely I had a discussion with Jae internally and there are few suggestion you need to make, internally DM you.
@msohailhussain & @jaeopt, I'm ready for another round of reviews.
I am still worried about how big this PR has become. Sorry.
Ready for another set of reviews ... or a LGTM4N Approval 😉 @msohailhussain @jaeopt @mnoman09
@mnoman09 I see where the FSC is failing. Is that what #325 is for?
Still holding for @msohailhussain 's approval (maybe if he's time).
@mnoman09 I'll hold for your merge and Approval too.
@msohailhussain @mnoman09 It looks like some FSC tests are erroring for this branch. Shall I start investigating the test app?
@msohailhussain @mnoman09 It looks like some FSC tests are erroring for this branch. Shall I start investigating the test app?
I can look at the testapp. Most of these tests are failing because we haven't merged the testapp PR: 79. Once we merge that PR FSC should pass.
Great. Thank you.
Is there something I can be helping with for getting FSC/test-app scenarios corrected?
@mnoman09 @msohailhussain
Is there something I can be helping with for getting FSC/test-app scenarios corrected?
@mnoman09 @msohailhussain
Is there something I can be helping with for getting FSC/test-app scenarios corrected?
@mnoman09 @msohailhussain
Is there something I can be helping with for getting FSC/test-app scenarios corrected?
@mnoman09 @msohailhussain
I will do by tomorrow.
I'm starting to understand FSC and the C# testapp. Working to figure out failing tests...
Thanks for the approval. FSC and the test app are my last blocker
OMG @msohailhussain and @mnoman09 You guys are the best.
Valuable lesson for me is to keep PR's much smaller.
I'll start working on the full-repo linting.
Thanks again, you guys.
Summary
This PR integrates ODP functionality with UserContext and Optimizely client to make it available for users. There are two ways to integrate ODPManager.
😬 Sorry about the numerous auto-format changes polluting the core enhancements. Need to satisfy the linter.
Test plan
Issues
FSSDK-8476