optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk
Apache License 2.0
19 stars 20 forks source link

Fix: Some suggested changes related to ODP #325

Closed mnoman09 closed 1 year ago

mnoman09 commented 1 year ago

Summary

Test plan

Tested it with FSC and all the Tests should pass on FSC.

Issues

FSSDK-8601

mikechu-optimizely commented 1 year ago

Hi @mnoman09

Would you want to merge this before #323? Do you have an FSSDK-#### number for the description?

Thanks.

mikechu-optimizely commented 1 year ago

Oh. Ignore the first question, I see you've been merging mike/odp-usercontext-optimizelyclient

mikechu-optimizely commented 1 year ago

Updated initial PR comment > Issues (<h2>) to include FSSDK-8601. Please update if in correct.

mnoman09 commented 1 year ago

Updated initial PR comment > Issues (<h2>) to include FSSDK-8601. Please update if in correct.

Yes, these are the few changes which are required to pass all the FSC tests. So you can merge it into mike/odp-usercontext-optimizelyclient.