[FSSDK-9090] Default instantiation of OdpManager for Optimizely constructors

[mikechu-optimizely]

Summary

• Fix OdpManager not having a default instantiation in Optimizely client

OptimizelyFactory provides a default which is desirable. The Optimizely constructors should follow this.

Test plan

• Add covering and passing unit test for Optimizely
• FSC integration tests should continue to pass

Issues

• FSSDK-9090

[jaeopt]

I have a question. How are we going to disable the odp? Previously we assumed that if user is not passing odpManager then it will be considered as disabled. In my opinion if someone is using OptimizelyFactory to initialize Optimizely then odpManager should be enabled by default otherwise do not initialize it and consider it disabled. @jaeopt What do you suggest?

ODP will be enabled by default and I see it can be disabled with the ODPManager builder. It may be inconvenient but should be ok for most use cases since enabled ODP functions will be ignored until they integrates ODP.

[mikechu-optimizely]

@mnoman09 I updated the https://github.com/optimizely/csharp-testapp/pull/83

[mikechu-optimizely]

Is it ok to have this PR open @jaeopt given my change to the test app to support FSC?

[jaeopt]

Is it ok to have this PR open @jaeopt given my change to the test app to support FSC?

@mikechu-optimizely oops, did I close the PR? I was wondering my comment has been broken and not realized I closed it by mistake. Sorry :)

[mikechu-optimizely]

Sweet. Passing now. I just hope I satisifed @mnoman09 's question to get a LGTM

[mikechu-optimizely]

Hey @mnoman09, I think you might be out, but I'm going to go ahead and merge this change. DM me if you wanna talk more about it. I'm happy to open more PRs to get it right.