Closed mikechu-optimizely closed 1 year ago
PRs #356 & #357 need to be merged into the release-branch before this one.
LGTM - Curious to know why fullstack check is failing.
LGTM - Curious to know why fullstack check is failing.
Great catch @muzahidul-opti I missed that because apparently I don't have the checks configured correctly. Let me look into both before continuing....
Oh wait, branch checks are configured for master
and we're merging into release-3.11.3
.
...but yeah why is optimizely/fullstack-sdk-compatibility-suite showing failure....hmmm
Found it.
I'm building SDK version 3.11.3, which does not have any coding for ATS/ODP. FSC is using end-to-end tests (csharp-testapp) that has ODP in play and expects the SDK to have the ODP classes so the build is failing
I need to think about how to use an older tag of the csharp-testapp that did not expect ODP to be present 🤔
@muzahidul-opti
Grrr. Ok. TestApp built successfully using an older non-ODP version, but now FSC itself needs to be run using a version before adding ODP.
58 failing tests all appear to be ODP.
@muzahidul-opti @jaeopt
@yasirfolio3 Is there a way to run FSC at a point before ODP tests?
Thanks @yasirfolio3 for pointing me in the direction of passing e2e testing for non ODP C# @muzahidul-opti for catching my oversight on e2e @jaeopt for your 3 reviews to get this out the door.
Summary
Test plan
Issues