optimizely / csharp-sdk

.NET based C# SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/csharp-sdk
Apache License 2.0
19 stars 20 forks source link

[FSSDK-9486] chore: Prepare for releasing 3.11.3 #358

Closed mikechu-optimizely closed 1 year ago

mikechu-optimizely commented 1 year ago

Summary

Test plan

Issues

mikechu-optimizely commented 1 year ago

PRs #356 & #357 need to be merged into the release-branch before this one.

muzahidul-opti commented 1 year ago

LGTM - Curious to know why fullstack check is failing.

mikechu-optimizely commented 1 year ago

LGTM - Curious to know why fullstack check is failing.

Great catch @muzahidul-opti I missed that because apparently I don't have the checks configured correctly. Let me look into both before continuing....

mikechu-optimizely commented 1 year ago

Oh wait, branch checks are configured for master and we're merging into release-3.11.3.

...but yeah why is optimizely/fullstack-sdk-compatibility-suite showing failure....hmmm

mikechu-optimizely commented 1 year ago

Found it.

I'm building SDK version 3.11.3, which does not have any coding for ATS/ODP. FSC is using end-to-end tests (csharp-testapp) that has ODP in play and expects the SDK to have the ODP classes so the build is failing

I need to think about how to use an older tag of the csharp-testapp that did not expect ODP to be present 🤔

@muzahidul-opti

mikechu-optimizely commented 1 year ago

Grrr. Ok. TestApp built successfully using an older non-ODP version, but now FSC itself needs to be run using a version before adding ODP.

58 failing tests all appear to be ODP.

@muzahidul-opti @jaeopt

mikechu-optimizely commented 1 year ago

@yasirfolio3 Is there a way to run FSC at a point before ODP tests?

mikechu-optimizely commented 1 year ago

Thanks @yasirfolio3 for pointing me in the direction of passing e2e testing for non ODP C# @muzahidul-opti for catching my oversight on e2e @jaeopt for your 3 reviews to get this out the door.