[FSSDK-10619] Refactor project config manager to be injectable

optimizely / javascript-sdk

JavaScript SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://www.optimizely.com/products/experiment/feature-experimentation/

Apache License 2.0

80 stars 82 forks source link

[FSSDK-10619] Refactor project config manager to be injectable #945

Closed raju-opti closed 2 months ago

raju-opti commented 2 months ago

Summary

This PR allows the user to create a ProjectConfigManager and pass it directly to createInstance. It exposes two factory methods createStaticProjectConfigManager and createPollingProjectConfigManager for this purpose.

Test plan

New tests have been added and relevant old tests has been updated

Issues

FSSDK-10619
FSSDK-10639
FSSDK-10641

coveralls commented 2 months ago

coverage: 89.201% (-1.1%) from 90.307% when pulling c483d858bcdf057e6ba9edfbdf5006f3931df253 on raju/pconf into e7cc602fb9526d78ec29fa298584bb01a3391645 on master.

mikechu-optimizely commented 2 months ago

Sorry I didn't get to this today. It's first on my list Mon