search

optimizely / library

Optimizely Library
Other
75 stars 70 forks source link

April/banner improvements #36

Closed aautrey4 closed 5 years ago

aautrey4 commented 5 years ago

We just recently implemented the banner (formerly butterbar) on the Academy to announce the upcoming path and certification changes, and I had a few suggested improvements. (I realized I should have put these as two pull requests, as you might not want to accept both).

Remove hash from URL: It was appending a hash tag to the end of a URL. I was using an anchor link and it was breaking it. So, it fixes that, as well as just general code clean-up. (e.g. https://www.optimizely.com/academy/#personas#).

Remove period: We wanted to use an exclamation point, and I had to go to the code to remove the hard-coded period. Just some flexibility for users that want to to control this.

CLAassistant commented 5 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: aautrey4
:x: April

April seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

aautrey4 commented 5 years ago

@asaschachar @bexcitement I have signed the CLA, but it isn't letting me proceed. I also saw the notice that my commits were tied to an unrecognized Github user, so I followed their instructions to ensure the email address is set correctly. Not sure how to proceed now?

asaschachar commented 5 years ago

@aautrey4 Changed some settings and you should be able to merge now. If not, I can merge for you.

As for your unrecognized Github user: I would check if subsequent commits are properly signed. You could check this by making a test PR that just changes something.

aautrey4 commented 5 years ago

ok, this is lame but I'm going to cancel this merge request and create a new one with the changes that are correctly mapped to my Github username. Sorry for all the trouble, but this seems like a quicker resolution than troubleshooting :)