optimizely / nuclear-js

Reactive Flux built with ImmutableJS data structures. Framework agnostic.

https://optimizely.github.io/nuclear-js/

MIT License

2.23k stars 141 forks source link

Jordan/fix group by getter #185

Open jordangarcia opened 9 years ago

jordangarcia commented 9 years ago

@lyonlai I checked out your branch and noticed a couple of test failures for some observer unwatch edge cases. I've added two new tests in master for these test cases and updated your branch to address these.

Mind giving this a PR before I merge?

183

lyonlai commented 9 years ago

@jordangarcia looks like you've missed the commit 77ced5e6358c2e515a29b2295bd73729834bd914 about the new test case in this PR.

jordangarcia commented 9 years ago

@lyonlai that commit is already in master and included in https://github.com/optimizely/nuclear-js/commit/f979b20235bdd51e37284671fcc0f91764fb2d5c

lyonlai commented 9 years ago

@jordangarcia I see. The code is good to go for me. :airplane:

bhamodi commented 9 years ago

LGTM too. :+1: