search

optimizely / objective-c-sdk

Optimizely X Objective-C SDK for iOS and tvOS
Apache License 2.0
24 stars 24 forks source link

(fix): there was a checkin with the client using new instead of alloc. new … #423

Closed thomaszurkan-optimizely closed 5 years ago

thomaszurkan-optimizely commented 5 years ago

…in objective-c causes an alloc and init. then, init is called again with a builder parameter. this seems to be causing a crash. This problem seems to be cropping up for a client on ios 12+.

Summary

Issues

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 98.153% when pulling 7e6d1d62cb6e7bea371ba6ee8c698c365daa0384 on fixClientInitMistake into 1de88a2bc504f5b615a03b4b2873a5996f6ddb83 on master.

gowthamyemme commented 5 years ago

We reported this bug. Thanks for fixing it. The fix looks good to me. 👍