(fix): get_variation input validation fixes.

optimizely / objective-c-sdk

Optimizely X Objective-C SDK for iOS and tvOS

Apache License 2.0

24 stars 24 forks source link

(fix): get_variation input validation fixes. #441

Closed yasirfolio3 closed 4 years ago

yasirfolio3 commented 4 years ago

Summary

Fixed issue for experimentKey and user_id validation for get_variation.
Notification was fired in every getVariation case where experimentKey was invalid.

TestPlan

Run testcases and here's the result. https://travis-ci.com/optimizely/fullstack-sdk-compatibility-suite/builds/144164489

coveralls commented 4 years ago

Coverage increased (+29.7%) to 98.112% when pulling 4593161f29de882d8d669d8c745118a3b55edbd8 on yasir/get-variation-fix into 138fff50735c390779654e45cb72d438b7e4fb08 on master.