fix: bucketing error at traffic allocation boundaries

optimizely / objective-c-sdk

Optimizely X Objective-C SDK for iOS and tvOS

Apache License 2.0

24 stars 24 forks source link

fix: bucketing error at traffic allocation boundaries #449

Closed jaeopt closed 4 years ago

jaeopt commented 4 years ago

Summary

This fixes a bug of bucketing at traffic allocation boundaries

EndOfRange should be compared with "less-than" but "less-than-equal" is used.
The bucket hashing generates 0 for userID+expID = “211314358930636871818513703488”.
When 0 <= 0, the bucketing interprets it as in-bucket by error, so returns a false result.

Test plan

Add more test cases to cover this case in unit tests and FSC.

Issues

OASIS-7150

coveralls commented 4 years ago

Coverage increased (+0.03%) to 98.138% when pulling 1ccf8327d90f3b1abbaefacc6b6c17a5e28c2484 on jae/bucket into d497ebeef6d8b76802c64ff16f2d8e2cfda36c9b on master.