Fix PyPy unit test failure

optimizely / python-sdk

Python SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/python-sdk

Apache License 2.0

32 stars 36 forks source link

Fix PyPy unit test failure #317

Closed Mat001 closed 3 years ago

Mat001 commented 3 years ago

Summary

Fixing unit tests failing on PyPy/PyPy3
bumped mmh3 library version to 3.0.0 as that helped eliminate some failures when testing locally

coveralls commented 3 years ago

Coverage remained the same at 95.883% when pulling 8b11e2351740f16730a72ff6b2f78ec7ee70dd6f on mpirnovar/fix_pypy into 5fefd2b7f07865ffbe117289ef34aabbb4c98be1 on master.

aliabbasrizvi commented 3 years ago

Seems like a risky change given dropped support for Python 2.7, 3.3, 3.4: https://github.com/hajimes/mmh3/blob/master/README.md

Mat001 commented 3 years ago

Seems like a risky change given dropped support for Python 2.7, 3.3, 3.4: https://github.com/hajimes/mmh3/blob/master/README.md

Good to see you, Ali! Well, PyPy / PyPy3 unit tests have been failing because of mmh3. Will not be rushing into breaking stuff for sure. Investigating atm ..

Mat001 commented 3 years ago

Addressed in #318 - note that failing dependency installations can be seen when expanding the view in TravisCI log console. A small triangle icon to the left of pip install -r requirements.txt...

Also debating if worth downgrading cryptography lib (which caused filures) because that will cause other py versions tests to fail in the future. MAybe better to make a note in README for pypy/pypy3 to require a diff cryptography version