[MAINTENANCE] Cleanup: Removed depreicated warnings relating to test …

optimizely / python-sdk

Python SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/python-sdk

Apache License 2.0

32 stars 36 forks source link

[MAINTENANCE] Cleanup: Removed depreicated warnings relating to test … #331

Closed The-inside-man closed 3 years ago

The-inside-man commented 3 years ago

Summary

Noticed many warnings related to deprecated usage. Updated to the Python recommended versions. assertRaisesRegexp -> assertRaisesRegex, assertEquals -> assertEqual, and isAlive() -> isAlive()

Test plan

Run through tests with prior Python versions for compatibility generated from this PR.

Issues

Not attached to any Jira

coveralls commented 3 years ago

Coverage remained the same at 95.838% when pulling f4e3f4bdbccdbc0efe703e37f04d09da49910824 on jbrown/testcases-remove-warnings into 7607cf4649556628a82518b460048144a58187c1 on master.

The-inside-man commented 3 years ago

looks like Python 2.7, pypy and pypy3 have issues with the newer items.

2.7 assertRaisesRegex not supported
pypy assertRaisesRegex not supported
pypy3 assertEqual not supported

Looks to have no issue with the isAlive() to is_alive() change across all versions.

The-inside-man commented 3 years ago

Will do more research on how to make compatible with older versions of python and come back to this.