search

optimizely / python-sdk

Python SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/python-sdk
Apache License 2.0
32 stars 36 forks source link

ISSUE-232---drop-mmh3-dependency #357

Closed GordonSo closed 3 years ago

GordonSo commented 3 years ago

Summary

What: This PR is to remove the mmh3 package dependency thus c++ requirement on the build environment. See discussion: in ISSUE-232, https://github.com/optimizely/python-sdk/issues/232#issue-542968370

Why: Windows OS developers are having to install c++ in order to use the package. It would be ideal to keep the code extendible at the import level but optional by choice for those who need it.

Test plan

Issues

GordonSo commented 3 years ago

OK, I see the tests are coupled to mmh3 too, I can fix this. But before I do, can I get a confirmation this is the right path to go down, please?

msohailhussain commented 3 years ago

Hi @GordonSo, We are actively working on it, will get back to you once we are done with our research and decision. @Mat001 FYI.

GordonSo commented 3 years ago

Closing this as it will be fixed by: https://github.com/optimizely/python-sdk/pull/362