Refact: Refactored Forced decision

optimizely / python-sdk

Python SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://docs.developers.optimizely.com/experimentation/v4.0.0-full-stack/docs/python-sdk

Apache License 2.0

32 stars 36 forks source link

Refact: Refactored Forced decision #365

Closed msohailhussain closed 2 years ago

msohailhussain commented 2 years ago

Summary

Removed get_variation_from_experiment_rule and get_variation_from_delivery_rule from decision service.
flag_variations_map logic improved using existing loops and removed get_all_variations_for_each_rule.
Unit test fixed.

Test plan

All FSC and unit tests should pass

coveralls commented 2 years ago

Coverage decreased (-0.2%) to 95.879% when pulling 39ab0b016a8f73f36be9c44c67c938e085143b1c on uzair/project-config-refactor into ab40d9e9a5958ee730d761cb574a864895be6376 on mpirnovar/forced_decisions.

msohailhussain commented 2 years ago

All lgtm, seems a few tests are failing in CI for pypy3, even after rerunning several times. I dont see this as a concern right now and can be addressed later as this seems to be a common issue with these versions of Python.

true.