[FSSDK-9062] add more support for sendOdpEvent error handling - Githubissues

optimizely / swift-sdk

Swift SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)

https://www.optimizely.com/products/full-stack/

Apache License 2.0

21 stars 30 forks source link

[FSSDK-9062] add more support for sendOdpEvent error handling #486

Closed jaeopt closed 1 year ago

jaeopt commented 1 year ago

Summary

Add more support for sendOdpEvent error handling:

empty string for action: throws odpInvalidAction
nil/empty for type: use default "fullstack" type
replace identifiers alias (fs-user-id/FS-USER-ID/FS_USER_ID) with fs_user_id

Include other clean-ups:

upgrade macOS (12), xcode(14.3), and simulators (15.5 and 16.1) in github actions (tests hangs with old versions).
upgrade local tests (Scrtips/test_all.sh) to cover a range of iOS versions (github actions not good for full coverage).

Test plan

Add unit tests covering all cases

Issues

FSSDK-9062