search

optimizely / swift-sdk

Swift SDK for Optimizely Feature Experimentation and Optimizely Full Stack (legacy)
https://www.optimizely.com/products/full-stack/
Apache License 2.0
21 stars 30 forks source link

Versioning and Swift-Packages #511

Closed ArturFriesen closed 1 year ago

ArturFriesen commented 1 year ago

The tag naming with the prefix "v" seems not to work with Swift-Packages. Example: We are referencing the exact version (.exact("3.10.2"). We are expecting to track the tag named "v3.10.2", but instead it seems like Swift-Packages is tracking the Branch with the name "3.10.2".

Proposal for a solution: The naming of tags should be without "v". This is the common approach in other repositories.

jaeopt commented 1 year ago

@ArturFriesen thanks for sharing the issue. Version numbering with "v" prefix is our versioning convention and SPM has no problem supporting it. The issue you observed is because we have an old branch accidentally named same as "3.10.2" and it might cause the conflict. We removed the branch. Let us know if you still see the issue.

ArturFriesen commented 1 year ago

@jaeopt Thanks for the fast fix! Learned something today. Indeed Swift SPM supports "v" prefix.