search

optimumBA / phx.tools

The easiest way to get started with Elixir and Phoenix Framework
https://phx.tools
9 stars 5 forks source link

Landing pages UI #19

Closed ngumokenneth closed 1 month ago

ngumokenneth commented 2 months ago

https://3.basecamp.com/5023736/buckets/38393000/todos/7682282318/

rowah commented 1 month ago

There's an extra file priv/static/Linux.sh. Please remove. There is an empty Linux.sh file which is the one you see as the extra file, I somehow introduced it with one of my previous commits (https://github.com/optimumBA/phx.tools/pull/19/commits/6248f3b9360bb31e424d3191e6455654da5fe93a) but now although github shows its an empty file, deleting it actually deletes the whole Linux scripts. I don't get what's going on.

almirsarajcic commented 1 month ago

There's an extra file priv/static/Linux.sh. Please remove.

There is an empty Linux.sh file which is the one you see as the extra file, I somehow introduced it with one of my previous commits (6248f3b) but now although github shows its an empty file, deleting it actually deletes the whole Linux scripts. I don't get what's going on.

That's because of the case change in the file name.

almirsarajcic commented 1 month ago

Looks good. We just need to change the IDs of ASCIINEMA recordings after they are done and we can merge this.