search

optiopay / klar

Integration of Clair and Docker Registry
MIT License
505 stars 138 forks source link

update base image in Dockerfile #53

Closed supereagle closed 7 years ago

supereagle commented 7 years ago

Fix #51: The klar image can not run as error exec user process caused "no such file or directory".

supereagle commented 7 years ago

@hashmap Please take a look, thanks.

nielsole commented 7 years ago

Not necessary if https://github.com/optiopay/klar/pull/58 is merged

hashmap commented 7 years ago

Should we close it since https://github.com/optiopay/klar/pull/58 has been merged?

supereagle commented 7 years ago

@nielsole Thanks for finding the root cause. This solution is much better, so this PR can be closed. Just the build command for Linux is updated, what about that for Mac? No need to update?

nielsole commented 7 years ago

AFAIK Cross-Compiling is always static, so as long as you compile for linux, it should be no problem.

nielsole commented 7 years ago

But apart from that it should be possible to combine the commands:

CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo .

That should be plattform agnostic. I don't have a mac to test this on, though.