search

opto / Expression-Search-NG

update of Thunderbird addon ExpressionSearch/Gmail UI for TB 78 and later
61 stars 8 forks source link

Now compatible with Thunderbird 102 #41

Open jaisekjames opened 2 years ago

jaisekjames commented 2 years ago

Please make compatible with TB 102. Release candidate 1 (RC1) is available at https://archive.mozilla.org/pub/thunderbird/candidates/102.0-candidates/build1/

Frank071 commented 2 years ago

I am puzzled as to whether this extension/add-on is still maintained. The Thunderbird page shows version 3.1, whereas here the repository is branded 2.4beta and the last release is 2.9. The text here is about moving towards TB 78, the text on the Thunderbird extension page is about moving towards TB 91 and clearly it is functioning under TB 91 already. So I hope 102 gets picked up...

opto commented 2 years ago

yes, it is maintained, and the update will come in the next days. Even some new stuff will come soon.

Klaus

jaisekjames commented 2 years ago

waiting for new features.

Frank071 commented 2 years ago

yes, it is maintained, and the update will come in the next days. Even some new stuff will come soon.

Great! Let us know if we can help

fp66 commented 2 years ago

I am puzzled as to whether this extension/add-on is still maintained. The Thunderbird page shows version 3.1, whereas here the repository is branded 2.4beta and the last release is 2.9. The text here is about moving towards TB 78, the text on the Thunderbird extension page is about moving towards TB 91 and clearly it is functioning under TB 91 already. So I hope 102 gets picked up...

In fact, the description should be adjusted. Klaus updated the extension to work with Tb 91 last year.

opto commented 2 years ago

We are again fighting with some strange timing stuff, where 1) TB lets the addon adjust the UI 2) TB overwrites and removes this, so the UI elements disappear

and the time for 1) is chosen by TB.

So the guesswork now is how to delay 1) so that it happens after 2)

jobisoft commented 2 years ago

ExpressionSearchNG_3.3.zip

Could you give this updated Version a try? This has been moved to WebExtension by a great extent and uses a different start/restart mechanism. After installing, I would suggest restarting Thunderbird, to have a clean environment.

Feedback is appreciated!

riedel commented 2 years ago

Feedback is appreciated! grafik

Works like a charm. Saved my day! I actually used it even without restarting (often did not work before). No issues yet. Anything specific to test?

jobisoft commented 2 years ago

Disable and re-enable the add-on and check if it still works (without restart). But at one time you need to make a fresh start to get all the old code out of the system, which did not properly remove itself from the old version.

Also: all the different settings which you know how they should behave and check it they still work as expected.

KeyBindings which you may have used before.

quentinDupont commented 2 years ago

ExpressionSearchNG_3.3.zip

Could you give this updated Version a try? This has been moved to WebExtension by a great extent and uses a different start/restart mechanism. After installing, I would suggest restarting Thunderbird, to have a clean environment.

Feedback is appreciated!

Tested and works like a charm ! I tested from body nt :heavy_check_mark: I tested to disable and renable :heavy_check_mark: I tested after a restart of Thunderbird :heavy_check_mark:

Bravo :clap: and thank youuuu !

Frank071 commented 2 years ago

ExpressionSearchNG_3.3.zip

Could you give this updated Version a try? This has been moved to WebExtension by a great extent and uses a different start/restart mechanism. After installing, I would suggest restarting Thunderbird, to have a clean environment.

Feedback is appreciated!

Tested on 102.0.1 - could not find any defects in this (limited) testround

jobisoft commented 2 years ago

This version re-enables to option to define a path for the ExpressionSearch virtual search folder: ExpressionSearchNG_3.4.zip

That was the last thing on my bucket list. Hope Klaus finds the time to review the changes and release this to ATN soon.

Frank071 commented 2 years ago

Question (perhaps I missed something): why isn't the code on GitHub in the usual way? That might make maintaining it a bit simpler as we could all chip in.

riedel commented 2 years ago

Hi, I also tested a bit and reenabling works. I never used it before, but I do not seem to be able to use one click search using the right mouse button.

jobisoft commented 2 years ago

It is CTRL+Right mouse click on the TO or FROM column entry, and it must be enabled in the settings. Works here.

Can you retry? Would a screenshot help, where you need to click?

riedel commented 2 years ago

OK it works, my bad: maybe it would be good to add to the description that it only works if you click on the correct column (may I overread it, but I actually was trying quite a bit)

jobisoft commented 2 years ago

maybe it would be good to add to the description

I leave that to Klaus :-)

El-Pazzo commented 2 years ago

Hi,

I got 2 issues with the new version:

  1. when saving a filter with an Expression Search - NG rule the condition is changed from "Match all of the following" to "Match any of the following". If I remove the Expression Search - NG condition and save it, then "Match all of the following" is saved as it should.
  2. the search term is not shown in the form field when reopening the rule (although it's correctly saved in the msgfilterrules.dat). I saw this issue with another filter addon (FiltaQuilla). Apparently the field does not get populated due to a change in TB a few versions ago. According to that addon's developer this issue can be solved easily by adapting the code to the new programming of TB.

Here is the rule as saved under msgfilterrules.dat:

name="HackAnhang" enabled="yes" type="17" action="Delete" condition="OR (expressionsearch#attachmentNameOrType,contains,.7z)"

(as you can see the condition is changed to "OR", but the search string is present)

The screenshot shows the filter after reopening it. It was save with "Match all of the following" and the Attachmeng Name/Type" field should show ".7z"

grafik

abyseedy commented 2 years ago

Hi,

I have installed ExpressionSearchNG_3.4.zip and I have noticed that whilst the Click2Search Setting (Ctrl+RightMouse click) still works for the Date and From columns, it no longer works on the Subject column. Could this please be fixed or am I doing something wrong?

Thanks.

jobisoft commented 2 years ago

Can you all (@abyseedy @El-Pazzo) please file individual issues for bugs found in v3.4? Please prepend [v3.4] to the issue's title.

Thanks

opto commented 2 years ago

will come officially soon.

I tested and found: only, filename and age broken. I haven't checked yet whether it was working in 91. Klaus

opto commented 2 years ago

see https://github.com/opto/Expression-Search-NG/releases/tag/v3.4.2, also uploaded to ATN.

jobisoft commented 2 years ago

Can you also update the repository itself, so the code is browsable on GitHub? The master branch still only has an XPI of v2.4, which is highly confusing (which is packed inside the "SourceCode" zip file of your v3.4.2 tag, which is even more confusing).

doak commented 2 years ago

Question (perhaps I missed something): why isn't the code on GitHub in the usual way? That might make maintaining it a bit simpler as we could all chip in.

It seems people here like to exchange ZIP files a lot. I though these times are gone for at least 15 years … :D

quentinDupont commented 2 years ago

Question (perhaps I missed something): why isn't the code on GitHub in the usual way? That might make maintaining it a bit simpler as we could all chip in.

It seems people here like to exchange ZIP files a lot. I though these times are gone for at least 15 years … :D

Since it's availaible on Thunderbird 102, I think this issue can be closed indeed :)

opto commented 2 years ago

Somewhere in this issue there is a reminder for me to an open task.

But I agree, the title should be changed because TB 102 original is on ATN, as well as a Bugfix, and the New fix for click2search is on gh and will go to ATN soon. Klaus

jfmoulin commented 2 years ago

On Thunderbird 102.2.2 under Linux Mint, I see Expression Search - NG as installed but I only get the crappy Quickfilter search, it does not use the ExprSearch regexp (I was using it daily before the upgrade to 102)... I reinstalled it to no avail. Any help much appreciated!

opto commented 2 years ago

thanks.

any red message in error console?

biva commented 2 years ago

I don't know if it's the same problem, but on Windows 11, TB 102.3.3 64bits, Expression Search addon 3.6.3, the addon works well when I start Thunderbird, but then disappears after some time. If I deactivate the addon, reactivate it and restart Thunderbird, it works fine again, and then disappears again. (disappear = I have only the normal Quick Filter toolbar)

I do see a lot of red messages in the error console, but I'd need to filter them to find something relevant. Which filter should I apply (when I filter with "expr" I don't see anything anymore, only this: image

biva commented 2 years ago

I investigated further:

zhump678 commented 1 year ago

It is CTRL+Right mouse click on the TO or FROM column entry, and it must be enabled in the settings. Works here.

Can you retry? Would a screenshot help, where you need to click?

Hi I am also experiencing the c2s issue, when I right click the FROM/TO entry holding ctrl, nothing happens but a normalright click menu appears, as in the screenshot:

image

Am I using the c2s in a wrong way? Could you kindly show me how it functions?

mnome commented 1 year ago

I investigated further:

  • If I restart Thunderbird only, without deactivating/activating the addon before, it doesn't work
  • If I deactivate/activate the addon only, I see this after some time (when the addon doesn't work anymore):

I'm also having this issue on Ubuntu 20.04, Thunderbird v102.7.1.