Update for TB 115 Supernova: "call" for donations

[opto]

I did a proof of concept, it is doable even with the new html structure of the main window.

The unreplied filter button works already, as well as a subset (s: f: t:) of the commands.

For this TB update (115), it is a lot of work, the main window structure has been totally changed, the quickfilterbarmuxer does not exist any longer, so donations are very much appreciated.

Donations by Paypal: https://www.paypal.com/donate?hosted_button_id=EMVA9S5N54UEW

many thanks, Klaus

[hi5]

~Last time~ for Nostalgy it was a bounty, will you open one again or will you open Github Sponsors?

[opto]

Thanks for the reminder.

Bountysource takes away a lot of money. I did not check for Github sponsors yet, but Paypal is reasonable, so I put the link into the top post and here: https://www.paypal.com/donate?hosted_button_id=EMVA9S5N54UEW

Thanks for considering and reminding me of a link.

Klaus

[hi5]

Donated (keep it anonymous please)

[oleole39]

Hello @opto, I do value ESNG (even though i personally at the moment only use the abbreviations features). Would you as well find helpful for your workflow to give directions and receive help in adapting the plugin to TB v115?

[Frank071]

Just got 115 and already missing ESNG. I donated a few days back and was wondering if you have a timeline? Not to hurry you, but simply to have some idea if it will take you days, weeks or months to get it ready. And supporting @oleole39 : let us know if you can do with some help.

[opto]

I have a version that sometimes shows two search boxes (one working), so search in folder is working. The general filters will come next week. ctrl click and other things: I don't know how much time that will need.

If the intermediate version is helpful, I can upload it here under releases, please let me know.

And thanks for offering help: some stuff needs deep knowledge of internal TB search and filters. But help would be appreciated in other stuff. For example: a) the notreply button is needed in a version for dark mode: skin/noreply1black.svg But I have no idea at the moment whether these icons are still loaded as svg image in 115 or in a class. I think in a first trial the loading as image was not displayed in 115. b) there are some proposals for colors in the popup in dark mode. (here on github). We need a second css file with those replacing the standard, and in loading the addon need to detect whether there is dark mode or not (I have that in some other addon - maybe Nostalgy++, or even here?), and add that code and load the other stylesheet under that condition.

If you are interested, I can put out some more info later. For a): how are the quickfilter bar icons loaded in 115 (find out in searchfox by looking at that code), then do the same for the unreplied. To start: load big debugger (ctrl shift I, ), goto inspector, click the little icon to its left: then you can click any item in TB windows and the inspector will jump there, so one can inspect the classes and knows which file/linenumber to look at in searchfox.

[oleole39]

help would be appreciated in other stuff. For example: [...]

I will be able to spend time on it by next week

[opto]

many thanks! If you need more guidance, please let me know.

[opto]

api/ExpressionSearch/implementation.js has this:

  if (prefersDarkMode)
    userCSS = Services.io.newURI("resource://expressionsearch/skin/overlaydark.css", null, null);

so maybe we just need to adjust that CSS file.

[Tragen]

Wouldn't it be easier to have one CSS and

@media (prefers-color-scheme: dark) {
...
}

[opto]

I am not so good in css, but if I remember right, there was a problem for old TB's where that does not work? There was something about detecting dark mode being different in older versions.

But it might be worth looking at, maybe that was before 91?

[Tragen]

Would the new update of ESNG be compatible with TB < 115 if you need to change so much code?

[opto]

yes, my plan is to have it for >< 115, so that future new features will be available in both old and new version.

[Tragen]

Any news on the progress?

[oleole39]

But help would be appreciated in other stuff. For example: a) the notreply button is needed in a version for dark mode: skin/noreply1black.svg But I have no idea at the moment whether these icons are still loaded as svg image in 115 or in a class. I think in a first trial the loading as image was not displayed in 115. b) there are some proposals for colors in the popup in dark mode. (here on github). We need a second css file with those replacing the standard, and in loading the addon need to detect whether there is dark mode or not (I have that in some other addon - maybe Nostalgy++, or even here?), and add that code and load the other stylesheet under that condition.

Hello @opto,

I adressed this dedicated issue your 2 points and came with an overhaul of the the dark theme feature that extends its coverage to all ESNG.

I have also set the last version of the extension distributed on TB addons website (3.8.11, dated July 3, 2023) as a Github repo on a fork for which I made a PR to this repo. I read elsewhere you were developping ESNG over 3 different repos, but maybe it would be easier now for you to centralise (for me it could be on any other software forge than GitHub if you prefer by the way) - I guess that would make things easier for the project to receive external code contributions.

Let us know if you wanna share other concerns (although I won't be much available by the next 2 weeks). Best, oleole39

[arkticrainbow]

Hi,

I just donated small amount (5eur+0.49), hope this helps a bit to get the ESNG up to 115. I really enjoyed using this addon on previous versions and could use is daily at work. This is first time I even considered donating.

Would it be possible to have early access to this addon as you go? I used to use "basic funcionality" of the addon.

Anyways, keep up the good work!

[Tragen]

Do you have a working beta we could test? I'm still not using TB 115 because I want to use this addon

[tmlmt]

There seems to be quite some willingness to help you @opto in taking this extension further, both through external collaboration (see PR #77), and donation.

About the latter, there are several requests in the issues list due to Paypal not being a desirable (e.g. request for an IBAN in #53) or even a feasible solution for folks in countries not easily supported by Paypal (e.g. Japan in #76 or #4; China in #75).

Could you work on these aspects? i.e. setting up for collaboration, and finding a better way to get sponsorship (why not try Github Sponsors? no fee for personal accounts).

[avegaweiss]

Team.....as day passes, I'm suffering with the default TB filter system....but getting more used to it. So.....can yo deliver a stable beta at least? Are any plan to continue with this addon?

[opto]

there is a first test version here: https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.0

basic filtering works, both in a folder and under ggeneral serach.

Don't use it < 115, I forgot to reset the minimum version.

Other things may work or not, if you find anything, please report.

The positioning to other places for the box is not yet implemented, but I thing the search itself is most important.

Klaus

[LAMepelle]

Thanks for the test version.

Unfortunately, issue #57 is still present and hence it can't be used on Thunderbird 115 for Mac.

[Inserm-CRI-LBI]

Thanks a lot also for the test version. It is not doing what is expected on my end (hitting return in the "Query Builder" window does nothing); looking at the logs I get the following: wind.QuickFilterBarMuxer is undefined implementation.js:208 setSearchValue jar:file:///C:/Users/****/AppData/Roaming/Thunderbird/Profiles/**.default/extensions/expressionsearch@opto.one.xpi!/api/ExpressionSearch/implementation.js:208 result resource://gre/modules/ExtensionParent.sys.mjs:1144 withCallContextData resource://gre/modules/ExtensionParent.sys.mjs:627 result resource://gre/modules/ExtensionParent.sys.mjs:1143 withPendingBrowser resource://gre/modules/ExtensionParent.sys.mjs:637 result resource://gre/modules/ExtensionParent.sys.mjs:1142 callAndLog resource://gre/modules/ExtensionParent.sys.mjs:1095 recvAPICall resource://gre/modules/ExtensionParent.sys.mjs:1141 InterpretGeneratorResume self-hosted:1455 AsyncFunctionNext self-hosted:852

[riedel]

Other things may work or not, if you find anything, please report.

Sticky does not work: need to fill in content again when switching folders.

[opto]

sticky doesn't even work in my TB 102 without expression search. But yes, it works in 115 without expression search.

maybe we need our own implementation for that?

[opto]

this version reenables the search query builder https://github.com/opto/Expression-Search-NG/releases/edit/untagged-24aca9b69211d37de494

[jfmoulin]

I tried https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.1 on a linux box (Mint 21.1) running Thunderbird 115.3.1. It did not complain on install and I was greeted by the upgrade page. But the search does not work. I just get the crappy thunderbird results

[opto]

this version reenables creation of a virtual folder (ctrl-Enter insearchbox) on win 11. https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.2

@jfmoulin thanks for the info on Linux, I did not try that yet.Are there any red messages in error console (ctrl-J in win)?

[opto]

automatic display of virtual folder comes in next version

[opto]

we now again have the searchglas in statusbar, and help and other menu items do work

[oleole39]

@jfmoulin @opto Tested ESNG 4.0.1 with Linux Mint 21 & TB 115.3.2 64bits (using a test profile with no other plugins installed than ESNG) and ESNG search actually does seem to work properly here.

Met a few console output errors though (not breaking the search feature):

• at plugin's activation: Unknown localization message info.xnote ExtensionCommon.sys.mjs:2082
• at search pop-up's opening: wind.gTabmail is undefined implementation.js:72 and

  Uncaught (in promise) Error: An unexpected error occurred
  main moz-extension://d6394796-9ce2-432f-92f1-8252d63f12bd/ex-background.js:242
  Async* moz-extension://d6394796-9ce2-432f-92f1-8252d63f12bd/ex-background.js:212
  undefined

[jfmoulin]

@opto @oleole39 Sorry for delayed answer. Things now seem to work. Thanks!

[opto]

new version https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.5

[opto]

test version for 128: https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.40