Open bstecklum opened 1 year ago
same issue here. e.g. when using the "open message in conversation" mode. With the plugin enabled I get a blank screen, with the plugin disabled it works as it should. Currently using Expression-Search-NG v4.0.1 .
Duplicate of https://github.com/opto/Expression-Search-NG/issues/82 (I have the same problem and come here regularly to check)
Just installed 4.0.2, but it did not solve the issue.
same here; v4.0.2 also gives blank pages
Same, Add on V 4.0.2 TB v115.4.1 / 64
In console i've got the error when (selecting Show verbose information in error console in addon params): on right click:
TypeError: ExpressionSearchChrome is undefined[ExpressionSearchChrome.jsm:999:15](resource://expressionsearch/modules/ExpressionSearchChrome.jsm)
onContextMenu resource://expressionsearch/modules/ExpressionSearchChrome.jsm:999
TypeError: ExpressionSearchChrome is undefined[ExpressionSearchChrome.jsm:1020:15](resource://expressionsearch/modules/ExpressionSearchChrome.jsm)
onContextMenu resource://expressionsearch/modules/ExpressionSearchChrome.jsm:1020
(this one, with or without the addon activated)
opening conversation in new tab:
Uncaught (in promise) TypeError: domNode is null
_bindUI chrome://messenger/content/quickFilterBar.js:321
init chrome://messenger/content/quickFilterBar.js:58
init chrome://messenger/content/about3Pane.js:4299
<anonymous> chrome://messenger/content/about3Pane.js:110
async* chrome://messenger/content/about3Pane.js:97
[quickFilterBar.js:321:11](chrome://messenger/content/quickFilterBar.js)
Uncaught TypeError: win.messageBrowser is undefined
openTab chrome://messenger/content/mailTabs.js:100
_cloneTemplate chrome://messenger/content/mailTabs.js:66
_cloneTemplate chrome://messenger/content/mailTabs.js:62
openTab chrome://messenger/content/mailTabs.js:90
openTab chrome://messenger/content/tabmail.js:879
onQueryCompleted resource:///modules/ConversationOpener.jsm:55
_onQueryCompleted resource:///modules/gloda/Collection.jsm:681
onQueryCompleted resource:///modules/gloda/GlodaDatastore.jsm:169
_onQueryCompleted resource:///modules/gloda/Collection.jsm:681
onQueryCompleted resource:///modules/gloda/GlodaDatastore.jsm:169
_onQueryCompleted resource:///modules/gloda/Collection.jsm:681
onQueryCompleted resource:///modules/gloda/GlodaDatastore.jsm:169
_onQueryCompleted resource:///modules/gloda/Collection.jsm:681
onQueryCompleted resource:///modules/gloda/GlodaDatastore.jsm:169
handleCompletion resource:///modules/gloda/GlodaDatastore.jsm:445
(specific when ExpressionSearch is enabled)
I assume that is the blank folder on TB restart.
resolved and some more features: https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.5
For me, the issue remain, when opening a "conversation in a new tab", the new tab is still blanked.
Same here with v4.0.5. Unfortunately, this doesn't seem to be resolved.
Some additional information.
Using Thunderbird 115.4.1 (64-bit) on Mac OS Using Expression Search NG v4.0.5
opening conversation in new tab gives these two errors in console:
Uncaught (in promise) TypeError: domNode is null
_bindUI chrome://messenger/content/quickFilterBar.js:321
init chrome://messenger/content/quickFilterBar.js:58
init chrome://messenger/content/about3Pane.js:4299
<anonymous> chrome://messenger/content/about3Pane.js:110
quickFilterBar.js:321:11
Uncaught TypeError: win.messageBrowser is undefined
openTab chrome://messenger/content/mailTabs.js:100
_cloneTemplate chrome://messenger/content/mailTabs.js:66
mailTabs.js:100:13
openTab chrome://messenger/content/mailTabs.js:100
_cloneTemplate chrome://messenger/content/mailTabs.js:66
Workaround: disble addon in addon manager, create new tab, reenable addon.
I have been working on this a full working day now. It is a very unfortunate bug in TB and most difficult to circumvent.
Our new filter has the search-textbox, and when opening your new tab for the other folder, TB tries to install the filter before we can insert the textbox. This is automatic in TB's code for opening the new tab. What they did wrong is make the quickfilterbar private to the tabs but the filterdefinitions are global and are applied before we can modify the tab (= add the searchbox).
So it all fails and the tab stays white.
So yesterday I have been looking for ways to add the box before TB adds the filterdefinitions, with no success. Next I will try to kill the filter upon adding tabs and reinsert the filter once the tab is there. Killing the filter before TB tries to add it does work already, so there is hope.
Thanks, Klaus, for making this valuable add-on working as usual again. Very much appreciated.
this does solve it here, please test
https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.8
just installed v4.0.8. unfortunately, seem issue here... Error log shows the exact same messages:
Uncaught (in promise) TypeError: domNode is null
_bindUI chrome://messenger/content/quickFilterBar.js:321
init chrome://messenger/content/quickFilterBar.js:58
init chrome://messenger/content/about3Pane.js:4298
<anonymous> chrome://messenger/content/about3Pane.js:111
quickFilterBar.js:321:11
Uncaught (in promise) TypeError: win.messageBrowser is undefined
openTab chrome://messenger/content/mailTabs.js:103
mailTabs.js:103:13
same here.
My logs on 'open discussion on new tab' shows:
TypeError: me is undefined ExpressionSearchChrome.jsm:1035:15 Uncaught (in promise) TypeError: domNode is null _bindUI chrome://messenger/content/quickFilterBar.js:321 init chrome://messenger/content/quickFilterBar.js:58 init chrome://messenger/content/about3Pane.js:4298
what happens if you deinstall, restart TB and install then?
Still blank : logs are :
Uncaught (in promise) TypeError: domNode is null
_bindUI chrome://messenger/content/quickFilterBar.js:321
init chrome://messenger/content/quickFilterBar.js:58
init chrome://messenger/content/about3Pane.js:4298
<anonymous> chrome://messenger/content/about3Pane.js:111
async* chrome://messenger/content/about3Pane.js:97
[quickFilterBar.js:321:11](chrome://messenger/content/quickFilterBar.js)
<anonyme> chrome://messenger/content/about3Pane.js:138
AsyncFunctionThrow self-hosted:856
(Asynchrone : async)
<anonyme> chrome://messenger/content/about3Pane.js:97
Uncaught (in promise) TypeError: win.messageBrowser is undefined
openTab chrome://messenger/content/mailTabs.js:103
_cloneTemplate chrome://messenger/content/mailTabs.js:66
_cloneTemplate chrome://messenger/content/mailTabs.js:62
openTab chrome://messenger/content/mailTabs.js:90
openTab chrome://messenger/content/tabmail.js:879
onQueryCompleted resource:///modules/ConversationOpener.jsm:55
_onQueryCompleted resource:///modules/gloda/Collection.jsm:681
onQueryCompleted resource:///modules/gloda/GlodaDatastore.jsm:169
handleCompletion resource:///mo
```dules/gloda/GlodaDatastore.jsm:445
which OS at your end, and TB version?
what happens if you deinstall, restart TB and install then?
Same result.
Using: Mac OS X 14.1 (23B74), Thunderbird 115.4.1 (64-bit), Expression Search NG v4.0.8
please try this https://github.com/opto/Expression-Search-NG/releases/tag/v4.0.9
v4.0.9 works! thank you!
my conf : Windows 10 pro 64 bits TB 115.4.2 (64 bits)
addon v4.0.9
I've unistalled addon v4.0.8, restart tb install v4.0.9 restart TB
Now when I do click on "open discussion", it does absolutely nothing. to revert to normal, I have to turn off the addon + restart TB.
My console show :
on addon activation :
WebExtensions: Expression Search / Google Mail UI startup... implementation.js:47
enabled add-on causes blank new folder tabs