opto / Imageview

Thunderbird addon to view images in attachments
Other
2 stars 2 forks source link

Get rid of the Utilities Experiment #6

Open jobisoft opened 2 months ago

jobisoft commented 2 months ago

All information should be available through the messages API. In order for me to contribute, please update the repository with the current code of the add-on.

jobisoft commented 1 month ago

I have looked at the required changes for Thunderbird 128 and removed the Utilities Experiment (replaced it by standard WebExtension API calls).

It seems the cutomUI Experiment does not work any more correctly, and I do not know how to fix it at the moment. Since the preview in the save dialog (which needs the CustomUI API) is not the main feature of this add-on, I propose removing it from the add-on. This makes it a pure WebExtension. I think that outweighs the loss of the preview feature. If you really want to bring that back later, you could do it in a separate add-on, to keep this one pure.

Attached you find my proposed update (version 3.0):

attachment_viewer_view_in_a_tab_slideshow-3.0-tb.zip

jobisoft commented 1 month ago

I did some more tests, but I am not able to get the custom_ui API to expand the save dialog and show the full image. I did do the conversion for you so that this code could run in the updated add-on in TB128 (without the Utilities API):

attachment_viewer_view_in_a_tab_slideshow-3.0.1-tb.zip

My recommendation is the following:

Note that my version 3.0.1 includes a modified custom_ui, which returns the tabId, where the save dialog was opened in.

While working on this, I saw that my version 3.0 has a console.log statement in background:111, which I forgot to remove.