opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
119 stars 9 forks source link

Copy messages with 'c' not working 91.6.1 (32 bit) Windows 10 Version 3.2.17 #167

Closed fespuela closed 2 years ago

fespuela commented 2 years ago

Hi,

Although move and go to messages with keys works, the hotkey copy function does not work. It seems that it does, but the message is not copied.

Thunderbird 91.6.1 (32 bit) Windows 10 Manage Emails/ Nostalgy++Version 3.2.17

Regards

vanous commented 2 years ago

Issue confirmed here on Linux too.

Nostalgy++Version 3.2.17 Thunderbird 91.6.1

opto commented 2 years ago

is this with more than 100 messages or all the time?

opto commented 2 years ago

I might revert back from webextension technology to the old version because we also don#t seem to have undo capability yet.

vanous commented 2 years ago

@opto it is even with just a single message...

fespuela commented 2 years ago

For me is just with only one message too. I tested with diferents IMAP accounts (gmail, dovecot), and also to folders and subfolders, with many messages and empties. Always the same, menu to copy when press c seems works, but in fact do nothing.

sinkva commented 2 years ago

Confirmed "c" (copy) function fails silently on MacOS, also.

MacOS 11.6.1 (Big Sur) Thunderbird 91.6.1 (64-bit) Nostalgy++ 3.2.17 Single and (quantity) two messages at a time

karlbu commented 2 years ago

Same here.

Olifair commented 2 years ago

I'm running TB 91.6.1 32bit and Nostalgy++ 3.2.17 on a windows 10 64bits laptop and I do not seem to have any problem, s,g,b and shift+s,g,b and alt+g work as expected from the main window (and I'm not using any folder filters, always showing all folders). I'm having a few other extensions installed (Copy Message ID, Copy Sent to Current, FiltaQuilla, ToggleHeaders) and they do not seem to interfere. I have tried to use the keys from the IMPA inbox to other IMAP folder and to local folders, all working. I thus wonder where the problem that people describe above lies ?

vanous commented 2 years ago

Problem is with 'c' (message copy), as indicated in the title.

Olifair commented 2 years ago

@vanous oups, sorry, for some reason didn't see that this was about copy, and yes, I can confirm that it isn't working here either.

bsgcic commented 2 years ago

Hi, First, a huge thank you to opto and the Nostalgy++ team. This is an indispensable add-on. Your doing a fantastic job! This bug is absolutely real, and from above appears to be present in all platforms. My system is: Ubuntu 20.04LTS (all updates applied), Thunderbird 91.5 (64-bit). This has been a huge issue since version 3.2.16 and also 3.2.17. I finally, yesterday realized that this problem was inherent in the Nostalgy++ code and appeared in 3.2.16 (January) which kind of has me in a bind because I had been assuming all the copying that I was doing was working and now, I know that there are tons of critical emails not correctly duplicated in different folders that I need them. Anyway, I removed 3.2.17 (I had also tested with replacing it with 3.2.16) and replaced it with 3.0.7 which works. Please note, that there is in addition issue in Thunderbird itself (and possibly Nostalgy++ 3.2.16 and 3.2.17) where (1) If I press CTRL and drag to another folder, it moves instead of copies; and (2) If I do "C" for copy, it instead moves it. That can happen before or after attempting to initially just do a "C" copy. By the way copy DOES work if I right-click on the email and select the "Copy To" menu item and select a recent folder.

Hope this helps, thank you again for this wonderful add-on, and keep up the great work.

opto commented 2 years ago

this is a really bad bug, because: it is working here. At least the drag an email with ctrl, it does copy.

As for Nostalgy copy, I have a hunch what might be (sometimes) wrong and will upload a test version soon.

Klaus

bsgcic commented 2 years ago

Hi Klaus, Thank you for your comment. Yeah, these types of intermittent bugs are indeed some of the toughest - always the hardest for me when I'm developing. It was very intermittent. I don't recall the series of steps that triggered it. I remember it was after I was trying to deal with the other problem on copying an email. I encountered that perhaps 3 or 4 times and on different days. Then I just started to use the right-click Copy-To which was dependable.

opto commented 2 years ago

please try this https://github.com/opto/nostalgy-xpi/releases/tag/v3.2.22

fespuela commented 2 years ago

I have done a speed test, and seems addon don't work. Not appears options in the addon menu (add shortcut keys and other options), and when press 'c' 's' or another shortcut key Thunderbid works like the addon not be insalled.

Tomorrow I will be able to try it more calmly

fespuela commented 2 years ago

Definitely I can't get the addon to work in this version (3.2.22).

When I install the addon, not appears options icon. And when restart, addon dissapear: https://imgur.com/URlT7BN

When press 'C' appears standard thunderbird option: https://imgur.com/oBrBkVg

opto commented 2 years ago

there was a bug in copy implementation, I do not remember whether already fixed in 3.2.22.

This https://github.com/opto/nostalgy-xpi/releases/tag/v3.2.24 reverts back to the old copy mechanism so that we get back undo, which is not implemented yet in webextension code.

options icon does appear here (also in 3.2.22). If not, you an use tools->Nostalgy++

k11i commented 2 years ago

Just installed https://github.com/opto/nostalgy-xpi/releases/tag/v3.2.24 on Linux 91.6.1 (64-bit) resulting in no functionality at all.

Icon to preference vanished from extension list and none of the usual shortcuts work anymore.

(BTW: after it had been working for some time again, in the last few days there has also been a regression, that shortcuts only work after changing tabs away and back again. But I'm sorry, I did not look which version I had installed then, should at least have been 3.0.11 since I installed this by hand mid january [Edit: but might have been automatically updated to 3.2.17]).

juancarretero commented 2 years ago

Clearly, this is a significant issue for all platforms. Does anyone know when this started? I have been using this tool for quite some time now and wondering how many copies I have been missing. If this has been going on for over 12 days (when the first post in this thread was created) it may mean several hours of work for me to recover all the missing copies of messages.

fespuela commented 2 years ago

Currently i'm using version 3.1.3 and works perfectly.

opto commented 2 years ago

this started when trying to use the new webextenson version for copy/move, which also has no undo.

Please use the new version under releases here on github https://github.com/opto/nostalgy-xpi/releases/tag/v3.2.24

juancarretero commented 2 years ago

Thank you opto!!

I am working on Ubuntu 21.10 and I have not been able to instal version 3.2.24 on top of the default (version 3.2.17 through the Add-ons Manager). Can anyone guide me to a how-to guide that would help me?

opto commented 2 years ago

the addons tab (in windows: extra-> addons) has a cog symbol, where you can install an addon from a file.

rjbutera commented 2 years ago

Hi Opto, V3.2.24 has fixed the issue for me. Thanks!

Bob Butera

On Mon, Mar 7, 2022 at 11:16 AM opto @.***> wrote:

this started when trying to use the new webextenson version for copy/move, which also has no undo.

Please use the new version under releases here on github https://github.com/opto/nostalgy-xpi/releases/tag/v3.2.24

— Reply to this email directly, view it on GitHub https://github.com/opto/nostalgy-xpi/issues/167#issuecomment-1060866864, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6DADNLJOLH3MARKRSLGW3U6YTW5ANCNFSM5PEQGIFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

opto commented 2 years ago

please try the newest release. I tested both on win 11 and Ubuntu 20:

please try this https://github.com/opto/nostalgy-xpi/releases/tag/v3.3.2

bsgcic commented 2 years ago
Hi Opto,
Thunderbird just updated on Ubuntu 20.04lts to
    91.7.0 (64-bit) and I installed v3.3.2.  So far looking good.  I
    was able to copy an email using the 'c' key, move the copied
    email using the 'm' key, copy an email pressing ctrl and
    dragging to another folder, and move the email dragging.  I'll
    keep this active and will let you know if I find anything.
Thank you for your excellent work!
    Jeff

On 3/21/22 9:51 AM, opto wrote:

  please try the newest release. I tested both on win
    11 and Ubuntu 20:
  please try this https://github.com/opto/nostalgy-xpi/releases/tag/v3.3.2
  —
    Reply to this email directly, view it on GitHub, or unsubscribe.
    You are receiving this because you commented.Message
      ID: ***@***.***>
  [
    {
    ***@***.***": "http://schema.org",
    ***@***.***": "EmailMessage",
    "potentialAction": {
    ***@***.***": "ViewAction",
    "target":

"https://github.com/opto/nostalgy-xpi/issues/167#issuecomment-1073922715","url": "https://github.com/opto/nostalgy-xpi/issues/167#issuecomment-1073922715", "name": "View Issue" }, "description": "View this Issue on GitHub", "publisher": { @.***": "Organization", "name": "GitHub", "url": "https://github.com" } } ]

rjbutera commented 1 year ago

please try this https://github.com/opto/nostalgy-xpi/releases/tag/v3.3.2

On Windows 10, after installing 3.3.2, any time I restart TB, copy messages with 'c' (or anything else) does not work in an open mail tab unless I

Bob Butera

On Mon, Mar 21, 2022 at 9:51 AM opto @.***> wrote:

please try the newest release. I tested both on win 11 and Ubuntu 20:

please try this https://github.com/opto/nostalgy-xpi/releases/tag/v3.3.2

— Reply to this email directly, view it on GitHub https://github.com/opto/nostalgy-xpi/issues/167#issuecomment-1073922715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6DADMDW3H3ESBHV76KT4DVBB5HXANCNFSM5PEQGIFA . You are receiving this because you are subscribed to this thread.Message ID: @.***>