opto / nostalgy-xpi

nostalgy addon updated for Thunderbird 68 and now Thunderbird 78 - 115. Original code by Alain Frisch.
Other
122 stars 9 forks source link

Bad experience with dark theme #177

Open ttamttam opened 2 years ago

ttamttam commented 2 years ago

When (this is my default setting) I select Thunderbird dark theme: — the Search++ button is not visible (maybe there is a way to have it's color inversed, depending on the theme?) — in the key shortcuts table, every second line is unreadable

Many thanks for your work on this essential addon!

fnxweb commented 2 years ago

I'd add that under dark mode (Linux) the Prefs window's Rules tab shows white-on-white text for every other (even) row. This can sort of be worked around as the text goes red when the row is selected.

zhoravdb commented 2 years ago

(I think this is a related issue.) When the Nostalgy Preferences are opened the tab labels (Rules, Completion, etc.) are all black on light and readable but when I select another tab the selected tab becomes totally light and the label can't be seen; this continues from that point until the preferences are closed and reopened. It occurs whether the light appearance was set using the Thunderbird light theme or the Mac's light setting (System Preferences/General/Appearance).

DrBoym commented 2 years ago

This problem still exists, making Nostalgy very hard to use with any dark scheme. See example from my screen with standard dark mode from TB. Should be an easy fix, right? Nostalgy status bar ?

joreiff commented 2 years ago

In case anyone is interested: The following CSS fixes the status bar issue shown by @DrBoym:

hbox.statusbar[insertbefore="unreadMessageCount"] {
    appearance: none !important;
}

image#me-help {
    filter: invert(1);
}

Simply add it to the chrome/userChrome.css file inside your profile folder and restart Thunderbird.

ttamttam commented 2 years ago

Could not. Because there is no chrome directory in my profile folder. And I observe no effect if I create the missing directory and the above file in it.

joreiff commented 2 years ago

The directory does not get created automatically, simply create it yourself. And for newer profiles, you might have to enable this feature in the config editor.

ttamttam commented 2 years ago

Great! Thank you for the instructions!

pkiff commented 2 years ago

Thanks for the simple fix @joreiff! I would note that this also fixes the display for anyone using using the DeepDark theme, including (for the most part) making the Nostalgy settings dialogs readable and usable.

opto commented 2 years ago

thanks for that. I have not yet found out how anaddon can find out about dark mode, otherwise Nostalgy could add this.

Klaus

opto commented 2 years ago

just did dark mode for expressionsearch-ng, so this will be coming in the next week or so.

fnxweb commented 2 years ago

I am trying but failing to apply the same workaround for the prefs window's tables in dark mode (above); I've added the following to my userChome.css (in my current profile), and seemingly enabled that in the config editor, but it doesn't work. In the debugger, I don't see evidence of userChrome.css being in the list of possible stylesheets (but don't know if I would). I'm wondering if it's something to do with the prefs. window being a popup (it requires normal debugger access to inspect, not the add-on debugger).

#nrules tr:nth-child(even), #nostalgy_key_rows tr:nth-child(even)
{
  background-color: #404040  !important;
}

If I add that in the debugger as a (temporary) custom rule, it does apply OK. I just can't come up with a way of having it work automatically.

bitwon commented 1 year ago

just did dark mode for expressionsearch-ng, so this will be coming in the next week or so.

@opto Any news on that topic?

ptyx-erd commented 1 year ago

1) enabling toolkit.legacyUserProfileCustomizations.stylesheets in the Thunderbird config editor 2) Adding /chrome/userChrome.css with the specified code inside (as @joreiff suggested) to the folder C:\Users\ USERNAME \AppData\Roaming\Thunderbird\Profiles\ PROFILE FOLDER NAME \ made this work after restarting thunderbird.

Thx all !

Also that would be great to incorporate this feature in the next version of Nostalgy++ as a majority of people are now using dark mode.